fix - remove "default" values in infocards #938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Datadog ReportBranch report: ✅ 0 Failed, 230 Passed, 36 Skipped, 34.55s Total Time |
harishv7
reviewed
Dec 17, 2024
harishv7
approved these changes
Dec 18, 2024
There was a problem hiding this comment.
@adriangohjw Should also fix the required error msg which is currently missing - can file a ticket for this
adriangohjw
deleted the
adriangohjw/isom-1670-infocards-title-and-description-default-to-placeholder-when
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Closes https://linear.app/ogp/issue/ISOM-1670/infocards-title-and-description-default-to-placeholder-when-empty
Solution
Breaking Changes
Bug Fixes:
defaultfieldsnote: there's a underlying issue with how we are rendering fields such that the "required" error message is not showing up. Should fix in a separate PR
Tests
https://www.loom.com/share/847ca1fac61b427aa0e3c68907605f59?sid=5908c1bc-892e-4893-9717-7961b79f3851